ipfs/kubo
Vedi su GitHubnamesys/routing.go imports dht package preventing dht.Quorum() from being used with a custom routing option
Open
#5957 aperta il 30 gen 2019
P3effort/hoursexp/intermediatehelp wantedstatus/ready
Metriche repository
- Star
- (13.906 star)
- Metriche merge PR
- (Merge medio 4g 2h) (28 PR mergiate in 30 g)
Descrizione
If a user is using a custom routing option (like for example, we are using a modified DHT in openbazaar) and they pass in a DhtRecordCount to namesys.Resolve. The routing resolver will call dht.Quorum(int(options.DhtRecordCount)) however, the dht package imported by routing.go is the native dht package and not the one set by the user. The quorum function doesn't apply the option to the custom routing option.
func Quorum(n int) ropts.Option {
return func(opts *ropts.Options) error {
if opts.Other == nil {
opts.Other = make(map[interface{}]interface{}, 1)
}
opts.Other[quorumOptionKey{}] = n
return nil
}
}
I think the issue using a struct defined inside the package for quorumOptionKey rather than, say, a string.