ionic-team/ionicons

Can you expose a part="svg" for the SVG content

Open

Aperta il 16 apr 2021

Vedi su GitHub
 (5 commenti) (9 reazioni) (0 assegnatari)TypeScript (17.256 star) (2083 fork)batch import
help wanted

Descrizione

When using it with custom icons : <ion-icon src="assets/icons/wifi.svg"></ion-icon> Because of the Shadow DOM we can't style at all the content of the SVG. Any custom SVG used is always a square because of the this css lines : https://github.com/ionic-team/ionicons/blob/8c2a507fcff2cb5f2edff60357ffd7feb70bb987/src/components/icon/icon.css#L27-L34 By adding a part="svg" it would be possible to have more flexibility to style the SVG from the outside. In my case setting height to auto, but it could be to change the color of a specific path or anything else.

Guida contributor

Tech stack
typescriptweb components
Dominio
frontend
Tipo issue
feature
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
2
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 hours
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
fresh
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
Understanding of Shadow DOMFamiliarity with CSS partsIonIcons component structure
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
70
Direzione di ricerca
To implement this feature, locate the icon component's template in the IonIcons source code, specifically the file referenced in the issue (src/components/icon/icon.css and related tsx/html). Add the part='svg' attribute to the SVG element inside the component's shadow DOM. Ensure that the change does not break existing functionality and that the SVG is properly exposed for external styling via CSS part selectors. Test with a custom SVG icon to verify that the part attribute is applied and styling works.