iodide-project/iodide

validate _all_ API args, break out API arg validation in #1703 into a little library that we can use to

Open

#1760 aperta il 22 apr 2019

Vedi su GitHub
 (0 commenti) (0 reazioni) (0 assegnatari)JavaScript (147 fork)batch import
good first issue

Metriche repository

Star
 (1483 star)
Metriche merge PR
 (Nessuna PR mergiata in 30 g)

Descrizione

following from @hamilton's nice file API argument validation in #1703, we should apply argument validation to all of the iodide API. in the process, we should break the argument validation into proptypes-style helper function

see: https://github.com/iodide-project/iodide/pull/1703#discussion_r274200088

export function loadFile(fileName, fetchType, variableName = undefined) {
  argType.validate({
    fileName: [fileName, argType.string],
    fetchType: [fetchType, argType.enum(FETCH_RETURN_TYPES)],
    variableName: [variableName, argType.string.optional]
  })
  return sendFileRequestToEditor(fileName, "LOAD_FILE", {
    fetchType
  }).request.then(handleResourceLoad(fetchType, variableName));
}

Guida contributor