internetarchive/openlibrary

Use --no-install-recommends in dockerfiles

Open

Aperta il 19 nov 2019

Vedi su GitHub
 (6 commenti) (0 reazioni) (1 assegnatario)Python (4626 star) (1172 fork)batch import
Good First IssueLead: @cdriniModule: DockerNeeds: ResponsePriority: 3Theme: DevelopmentType: Refactor/Clean-up

Descrizione

Anywhere we use apt-get install in our Dockerfiles, we should also add --no-install-recommends. According to https://ubuntu.com/blog/we-reduced-our-docker-images-by-60-with-no-install-recommends this creates smaller images which build faster. Note:

It is important to keep in mind that doing this could result in some missing libraries in your projects which you may have to add back explicitly, but this will ultimately give you more control in the dependencies in your project.

Guida contributor

Tech stack
dockershell
Dominio
infrastructurebuild system
Tipo issue
refactor
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
2
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 hours
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
blocked
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
Basic knowledge of DockerFamiliarity with apt get
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
40
Direzione di ricerca
The issue is assigned to someone and has no linked PRs. Review all Dockerfiles in the repository (e.g., Dockerfile, docker compose files) for apt get install commands. Add the no install recommends flag to each occurrence. Be aware that removing recommended packages may cause missing dependencies; test the resulting Docker images to ensure functionality. The maintainer's note advises that missing libraries may need to be added back explicitly.