import-js/eslint-plugin-import
no-restricted-paths - absolute path expected where relative path is provided
Aperta
#1890 aperta il 24 ago 2020
help wanted
Metriche repository
- Star
- (5939 stelle)
- Metriche merge PR
- (Merge medio 138g 22h) (3 PR mergiate in 30 g)
Descrizione
I am having trouble with the configuration for this rule and believe there is a bug in the way paths are resolved
// see https://github.com/benmosher/eslint-plugin-import/blob/master/src/rules/no-restricted-paths.js#L72
// it returns a relative path, are we sure thats what we want?
const absoluteImportPath = resolve(importPath, context)
Here we use resolve which comes from utils/resolve and it returns a relative path
should we be using path.resolve to return an absolute path instead? I am happy to open a PR with the change once confirmed
to be clear the change I am proposing is
- const absoluteImportPath = resolve(basePath, context)
+ const absoluteImportPath = path.resolve(basePath, importPath);