import-js/eslint-plugin-import

pathGroups and alphabetize collision problems

Open

#1669 aperta il 24 feb 2020

Vedi su GitHub
 (3 commenti) (0 reazioni) (0 assegnatari)JavaScript (1540 fork)batch import
bughelp wanted

Metriche repository

Star
 (4946 star)
Metriche merge PR
 (Merge medio 138g 22h) (3 PR mergiate in 30 g)

Descrizione

Hello! Thanks for great and really helpful plugin! You did a great job! :)

For now I am trying to extend default config with pathGroups. I need to mark

import { xxx } from 'shared/xxx/xxx....'

as internal import that should be placed at the begin of internal imports.

My config is

        "import/order": [ "error", {
            "alphabetize": {
                "order": "asc",
                "caseInsensitive": true
            },
            "groups": [ "builtin", "external", "internal", "parent", "index", "sibling", "unknown" ],
            "pathGroups": [
                {
                    "pattern": "shared/**",
                    "group": "internal",
                    "position": "before"
                }
            ]
        } ],

And I have error here

import { FormatMessage, useFormatMessage } from '@comparaonline/react-intl-hooks';
import React, { FC } from 'react';
import InfiniteScroll from 'react-infinite-scroller';
import { connect } from 'react-redux';
import useDeepCompareEffect from 'use-deep-compare-effect';  // <= THIS LINE HAS ERROR

import './scrolled-channels-list.component.scss';
import { SearchConfigState } from 'shared/components/search-panel/store/search.model';
import { ChannelItem, SearchChannelsConfig } from 'shared/services/channel-api/channel-api.service';
import { ChannelComponent } from '../channel/channel.component';
import * as channelsActions from '../store/channels.actions';
import { ChannelsState } from '../store/channels.model';
import * as channelsSelectors from '../store/channels.selectors';
import { MoreChannelsLoadingComponent } from './more-channels-loading/more-channels-loading.component';
ESLint: `use-deep-compare-effect` import should occur after import of `shared/services/channel-api/channel-api.service`(import/order)

I also try to add

"pathGroupsExcludedImportTypes": [ "builtin", "external", "internal" ]

But nothing changed. Only helped to remove from config

            "alphabetize": {
                "order": "asc",
                "caseInsensitive": true
            },

Is this a bug or I not understand something?

Guida contributor