hyperstack-org/hyperstack

add support for importing new react memo component type

Open

#305 aperta il 14 apr 2020

Vedi su GitHub
 (0 commenti) (0 reazioni) (0 assegnatari)JavaScript (43 fork)batch import
bugcompatibilitygood first issue

Metriche repository

Star
 (531 star)
Metriche merge PR
 (Nessuna PR mergiata in 30 g)

Descrizione

react now has a component type called memo.

Need to detect when importing. For example the Material UI Icon Library is all built using memo type components.

Here is the patch:

module Hyperstack
  module Internal
    module Component
      class ReactWrapper
        def self.eval_native_react_component(name)
          component = `eval(name)`
          raise "#{name} is not defined" if `#{component} === undefined`
          component = `component.default` if `component.__esModule && component.default`
          is_component_class = `#{component}.prototype !== undefined` &&
                                (`!!#{component}.prototype.isReactComponent` ||
                                 `!!#{component}.prototype.render`)
          is_memo = `#{component}.type != undefined` && `typeof #{component}.type.render === "function"`
          has_render_method = `typeof #{component}.render === "function"`
          unless is_component_class || stateless?(component) || has_render_method || is_memo
            raise 'does not appear to be a native react component'
          end
          component
        end
      end
    end
  end
end

For now there is no work around, you have to apply the patch.

(Note this patch also incorporates the patch for #231)

Guida contributor