huginn/huginn

Using an additional single quote in Liquid var causes process get stuck

Aperta

#2584 aperta il 14 ago 2019

 (1 commento) (0 reazioni) (0 assegnatari)Ruby (4264 fork)batch import
bughelp wanted

Metriche repository

Star
 (49.270 stelle)
Metriche merge PR
 (Merge medio 4g 2h) (15 PR mergiate in 30 g)

Descrizione

Monkey-patch added here broke liquid template parse.

Example:

string = {
  "a": {
    "type": "text",
    "value": "{{ data['I'm using another single quote'] }}"
  },
  "b": {
    "type": "text",
    "value": "{{ data['some text'] }}"
  }
}.to_json
Liquid::Template.parse(string)

or:

string = {
  "a": {
    "type": "text",
    "value": "{{ data['I\'m using another single quote'] }}"
  },
  "b": {
    "type": "text",
    "value": "{{ data['some text'] }}"
  }
}.to_json
Liquid::Template.parse(string)

ref: https://github.com/Shopify/liquid/issues/1110

Guida contributor