huggingface/diffusers

Any chance class members like self._interrupt could be defined in __init__ across pipelines?

Open

#11.002 aperta il 7 mar 2025

Vedi su GitHub
 (11 commenti) (0 reazioni) (0 assegnatari)Python (4562 fork)batch import
bugcontributions-welcomehelp wantedstale

Metriche repository

Star
 (22.190 star)
Metriche merge PR
 (Merge medio 13g 1h) (96 PR mergiate in 30 g)

Descrizione

Describe the bug

I think there is no benefit to late initializing here and it puts a burden on the library user that could be easily avoided. Also leads to some confusion as it is uncommon, code inspection flags this. Let me know if I'm missing something.

Reproduction

class WanImageToVideoPipeline:
	def __init__(self):
		pass
	
	def __call__(self, *args, **kwargs):
		self._interrupt = False
		return 23

	@property
	def interrupt(self):
		return self._interrupt
	
pipe = WanImageToVideoPipeline()

def on_async_user_abort_call_me_any_time():
	# check if already interrupted but mid step
	print(pipe.interrupt)


on_async_user_abort_call_me_any_time()

Logs

AttributeError: 'WanImageToVideoPipeline' object has no attribute '_interrupt'. Did you mean: 'interrupt'?

System Info

Diffusers 0.33.0.dev0, Linux, Python 3.10

Who can help?

@yiyixuxu @DN6

Guida contributor