hovancik/stretchly

Feature request: Disable break sub-options if the break is disabled

Aperta

#773 aperta il 18 nov 2020

 (5 commenti) (1 reazione) (2 assegnatari)JavaScript (552 fork)batch import
good first issuehelp wanted

Metriche repository

Star
 (6470 stelle)
Metriche merge PR
 (Merge medio 2g 7h) (14 PR mergiate in 30 g)

Descrizione

Prerequisites

Description

I realised when I disabled Mini breaks, I would still get the notification before mini break starts. That's because I forgot to turn the option 'Show notification before Mini Break starts' option off, it might be a good idea to disable any sub-options as well (grey out) if the main break option is disabled.

Operating system: Windows 10

Steps to Reproduce

  1. Toggle 'Show notification beforee Mini Break starts' to 'On'
  2. Toggle 'Enable Mini Breaks' to 'Off' image

Expected behavior:

  • The sub-options for showing a notification or enable postponement are unchecked OR
  • The sub option values are kept but they are greyed out and not active.
  • May be even consider hiding the the Break for: and Every: options (if Mini breaks is not enabled then the sub options are probably just taking up extra space)

Actual behavior: [What actually happens]

The notification still came up for me. image

Reproduces how often: [What percentage of the time does it reproduce?]

Can't check at the moment, but I can report back when I get a chance.

Guida contributor