guardicore/monkey

Invalid configurations can be exported in the UI

Open

Aperta il 15 set 2023

Vedi su GitHub
 (0 commenti) (0 reazioni) (0 assegnatari)Python (6250 star) (752 fork)batch import
BugComplexity: MediumHelp wantedImpact: LowUI

Descrizione

Describe the bug

While an invalid configuration can't be submitted through the UI, it can be exported.

Trying to import that configuration in the UI isn't allowed, so it could be frustrating for a user who didn't realise that some values were invalid while exporting.

To Reproduce

Steps to reproduce the behavior:

  1. Run Island
  2. Add invalid configuration value somewhere
  3. Try submitting and see warning box
  4. Export and check the exported configuration for invalid value

Expected behavior

Don't allow exporting configuration if some values are invalid.

Screenshots

  1. Added invalid IP to configuration image

  2. Export modal works normally, but a warning is shown on the configuration page image

  3. Warning box image

  4. Exported configuration image

Guida contributor

Tech stack
python
Dominio
apibackend
Tipo issue
bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
2
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
under 1 hour
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
fresh
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
Nessuno
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
85
Direzione di ricerca
Investigate the configuration export endpoint in the backend (likely in a Python file handling configuration). Check if there is existing validation logic used during configuration submission and apply it before export. Look at the UI export component to understand the flow. The warning box suggests validation already exists; ensure it's triggered on export as well.