guardicore/monkey

Unify modal window styles

Open

Aperta il 26 feb 2021

Vedi su GitHub
 (0 commenti) (0 reazioni) (0 assegnatari)Python (6250 star) (752 fork)batch import
Beginner friendlyComplexity: LowHelp wantedImpact: MediumUI

Descrizione

Some modal windows have their style inlined in their JSX:

https://github.com/guardicore/monkey/blob/bc3283c4a5177c7d08ff65bb13370d061aae60d3/monkey/monkey_island/cc/ui/src/components/ui-components/IslandMonkeyRunErrorModal.js#L72-L82

https://github.com/guardicore/monkey/blob/bc3283c4a5177c7d08ff65bb13370d061aae60d3/monkey/monkey_island/cc/ui/src/components/pages/ConfigurePage.js#L178-L195

https://github.com/guardicore/monkey/blob/26dc2aeb146a50651a0df223d979a0fdf2161a5c/monkey/monkey_island/cc/ui/src/components/configuration-components/UnsafeOptionsConfirmationModal.js#L7-L27

Other modals, such as ImageModal and ScoutsuiteRuleModal have separate style sheets.

Unify the styles for all modal windows. Use style sheets instead of hardcoding style in the JSX

Guida contributor

Tech stack
javascriptreactcss
Dominio
frontend
Tipo issue
refactor
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
2
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
half day
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
fresh
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
basic React knowledgeCSS
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
80
Direzione di ricerca
Identify all modal components that have inline styles in JSX. Use the provided links as starting points (e.g., IslandMonkeyRunErrorModal.js, ConfigurePage.js, UnsafeOptionsConfirmationModal.js). Extract the inline styles and create CSS modules or stylesheets for each modal. Ensure the styles are consistent with existing modal stylesheets like those in ImageModal and ScoutsuiteRuleModal. Test by running the UI and verifying the modals display correctly.