grpc/grpc-java

Recommended IntelliJ code style settings are out of date

Open

Aperta il 10 lug 2015

Vedi su GitHub
 (5 commenti) (0 reazioni) (0 assegnatari)Java (11.124 star) (3742 fork)batch import
help wanted

Descrizione

I downloaded and imported the GoogleStyle code style settings xml, as recommended in Contributing.md. It doesn't seem like this project and its checkstyle are actually conforming to those style settings (which is fine, I like the prevailing gRPC style better!) A few things in particular keep coming up:

  • Import order: GoogleStyle has static imports at the bottom, doesn't separate grpc imports. This is configured in Code Style > Java > Imports > Import Layout.
  • Method argument wrapping: GoogleStyle has method call arguments and declaration parameters on the next line aligned to the opening paren. This is configured in Code Style > Java > Wrapping and Braces > Method declaration parameters > Align when multiline, as well as the same option under Method call arguments.

Guida contributor

Tech stack
java
Dominio
developer experience
Tipo issue
chore
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
2
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 hours
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
IntelliJ IDEABasic knowledge of Java code style
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
80
Direzione di ricerca
Update the IntelliJ code style settings XML file to match the project's actual style, particularly import order and method argument wrapping. Also update the Contributing.md to reflect the current recommended settings. Refer to the existing checkstyle configuration for guidance.