grpc/grpc-java

Support --incompatible_enable_proto_toolchain_resolution

Open

Aperta il 6 mag 2024

Vedi su GitHub
 (8 commenti) (4 reazioni) (0 assegnatari)Java (11.124 star) (3742 fork)batch import
Waiting on reporterenhancementhelp wanted

Descrizione

Is your feature request related to a problem?

The problem is need to compile protoc instead of using prebuilt binary while building java_grpc_library

Describe the solution you'd like

Support --incompatible_enable_proto_toolchain_resolution bazel flag so users can override protoc compiled from sources with prebuilt binary, as already done in rules_python or WIP in rules_go

Describe alternatives you've considered

Additional context

Examples of declarations toolchains for other languages that already support the feature here

Guida contributor

Tech stack
java
Dominio
build systembackend
Tipo issue
feature
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-2 days
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
active
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
BazelJavagRPCProtobuf toolchains
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
45
Direzione di ricerca
Study the referenced PRs in rules python and rules go to understand the pattern for supporting incompatible enable proto toolchain resolution. Examine the example toolchain declarations in aspect build/toolchains protoc. Then implement similar toolchain registration in grpc java's Bazel build files, likely in the grpc java repository's BUILD files or proto rules. Coordinate with maintainers to ensure compatibility.