grommet/grommet

Calendar header is re-rendering on hovering over days

Open

Aperta il 27 mar 2023

Vedi su GitHub
 (1 commento) (0 reazioni) (0 assegnatari)JavaScript (8247 star) (1015 fork)batch import
bughelp wanted

Descrizione

Expected Behavior

I don't know if this is intentional or not, thus I don't have an expected behavior (but still why is that happening?)

Actual Behavior

Calendar header is re-rendering again and again on hovering over calendar days (not the week days (sunday, monday...))

URL, screen shot, or Codepen exhibiting the issue

image image

Steps to Reproduce

Your Environment

  • Grommet version: latest
  • Browser Name and version: chrome@latest
  • Operating System and version (desktop or mobile): Desktop(Ubuntu 22.04)

Guida contributor

Tech stack
javascriptreact
Dominio
frontend
Tipo issue
bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
half day
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
fresh
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
needs investigation
Prerequisiti
React knowledgeUnderstanding of component re rendering
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
60
Direzione di ricerca
Investigate the Calendar component in Grommet (likely in src/js/components/Calendar). The issue reports that hovering over days causes the header to re render. Check if the hover state is stored in a context or parent component that triggers unnecessary re renders. Look for missing React.memo or useCallback optimizations. The user did not provide a reproducible example but described the behavior clearly.