grommet/grommet

Add a .gitattributes file to enforce line endings

Open

Aperta il 7 ott 2019

Vedi su GitHub
 (4 commenti) (0 reazioni) (0 assegnatari)JavaScript (8247 star) (1015 fork)batch import
enhancementgood first issue

Descrizione

Expected Behavior

People using Windows and Linux can commit with the same line endings (LF)

Actual Behavior

Windows users with mis-configured git clients commit files with CRLF line endings.

URL, screen shot, or Codepen exhibiting the issue

Example: https://github.com/grommet/grommet/issues/3394#issuecomment-539166085

Steps to Reproduce

Clone grommet from a Windows PC, then try to commit some changes.

Your Environment

  • Operating System and version (desktop or mobile): Windows

Solution

A simple .gitattributes file that enforce line endings for text files. Github also has an article about it: https://help.github.com/en/articles/configuring-git-to-handle-line-endings

Guida contributor

Tech stack
Nessuno
Dominio
developer experiencetooling
Tipo issue
feature
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
1
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
under 1 hour
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
basic git knowledge
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
90
Direzione di ricerca
Create a .gitattributes file in the root of the repository. The file should contain a pattern like `* text=auto` to normalize line endings to LF, and optionally specify `*.js text eol=lf` for JavaScript files. Reference the GitHub article on configuring git to handle line endings (https://help.github.com/en/articles/configuring git to handle line endings) for guidance.