graphql-python/graphene-django

GraphQLView should detect batch requests

Open

Aperta il 21 mag 2020

Vedi su GitHub
 (7 commenti) (1 reazione) (0 assegnatari)Python (4173 star) (754 fork)batch import
help wanted✨enhancement

Descrizione

Is there a valid reason why the GraphQLView input is validated to either only ever accept batched requests or never accept batched requests. Is it not reasonable to accept both?

https://github.com/graphql-python/graphene-django/blob/ee120c48e16dda818cb253fdc36b7053402956b0/graphene_django/views.py#L217

Guida contributor

Tech stack
pythondjangographql
Dominio
backendapi
Tipo issue
feature
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
half day
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
Basic Django knowledgeGraphQL basics
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
80
Direzione di ricerca
The issue requests modifying the GraphQLView in graphene django/views.py to detect and accept both batched and single GraphQL requests. The relevant code is at line 217 (linked in the issue). Currently, the view validates the input to expect either a list or a single object, but not both. A first time contributor should examine the parse body or dispatch method to implement logic that checks the request body type (list or dict) and processes accordingly. The goal is to allow a client to send either format without breaking existing functionality.