grafana/pyroscope

UI should show better error when connecting to UI at wrong components

Open

Aperta il 22 nov 2023

Vedi su GitHub
 (0 commenti) (1 reazione) (0 assegnatari)C (9041 star) (528 fork)batch import
frontendgood first issuehelp wanted

Descrizione

Currently when opening the UI in micro-services mode and you pick a component that is not a querier or query-frontend, we show 405 errors (as the local query APIs are unavailable). Instead we should direct the user to connect to the query-frontend instead.

The only useful UI functions are probably the admin ones in this case

Guida contributor

Tech stack
javascripttypescriptreact
Dominio
frontend
Tipo issue
feature
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
2
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 hours
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
fresh
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
Basic understanding of React componentsFamiliarity with error handling patterns
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
70
Direzione di ricerca
Investigate the current error handling in the UI, particularly the API call that returns 405 errors. Look at the UI components responsible for displaying query errors, likely in the frontend directory. The improvement should detect when a user connects to a non query component and instead show a message directing them to the query frontend. Examine existing error handling logic in files like 'src/components/QueryError.jsx' or similar to understand the pattern.