grafana/k6

Run tests in separate process so that we actually test loading proto definitions at runtime

Open

Aperta il 5 lug 2023

Vedi su GitHub
 (1 commento) (0 reazioni) (0 assegnatari)Go (30.564 star) (1537 fork)batch import
area: grpccihelp wantedtests

Descrizione

Originally raised in this comment by @thiagodpf.

What?

The current unit tests run the server and clients in the same process.

gRPC seems to have a global registry for types, so once the server loads them, the client doesn't need to.

This means that all tests that test that clients actually manage to load types correctly only with .proto files are not actually testing that :(

Solutions:

Preferably go test ./... should run the unit tests with the server and client as separate process - preferably even separate from the main go test one :thinking:

This sounds involved.

A quicker solution will be to have another CI step that runs a server + k6 run script.js exercising the most common cases.

Both will be best.

Guida contributor

Tech stack
gojavascript
Dominio
testing
Tipo issue
test
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-2 days
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
fresh
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
mostly clear
Prerequisiti
Go programmingtesting experiencegRPC basics
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
30
Direzione di ricerca
Investigate the current test structure in the k6 repository, particularly around gRPC tests. The issue references a comment in issue #3160. Consider implementing a CI step that runs a server and executes 'k6 run script.js' to test proto loading, or refactor unit tests to use separate processes. Review the existing test files for gRPC and the CI configuration (e.g., GitHub Actions workflows) to determine the best approach.