google/comprehensive-rust

Don't silence warnings in exercises

Open

#71 aperta il 27 dic 2022

Vedi su GitHub
 (4 commenti) (3 reazioni) (0 assegnatari)Rust (2009 fork)batch import
enhancementhelp wanted

Metriche repository

Star
 (32.954 star)
Metriche merge PR
 (Merge medio 9g 23h) (36 PR mergiate in 30 g)

Descrizione

All the exercises start with something like

// TODO: remove this when you're done with your implementation.
#![allow(unused_variables, dead_code)]

You're training people that it's normal and a good idea to ignore warnings during development. Instead, continue to emphasize what you mention in passing elsewhere -- Rust has great compiler errors!

Of course it's going to have a lot of warnings at the start since you've given them incomplete code. You can

  • Just let them deal with it
  • Or mention RUSTFLAGS=-A... cargo ... perhaps

But you shouldn't imply ignoring warnings until you're "done with your implementation" is a good idea, or IMO that ignoring warnings in your source code (as opposed to a command line flag) is a good idea.

Guida contributor