google/benchmark

[BUG] pkg-config file is broken when CMAKE_INSTALL_{INCLUDE,LIB}DIR is absolute

Chiusa

#1396 aperta il 16 mag 2022

Vedi su GitHubGuida contributor
 (1 commento) (0 reazioni) (0 assegnatari)C++ (1539 fork)batch import
help wanted

Metriche repository

Star
 (7968 stelle)
Metriche merge PR
 (Merge medio 4g 2h) (19 PR mergiate in 30 g)

Descrizione

Describe the bug

As per title: cmake/benchmark.pc.in has

prefix=@CMAKE_INSTALL_PREFIX@
exec_prefix=${prefix}
libdir=${prefix}/@CMAKE_INSTALL_LIBDIR@
includedir=${prefix}/@CMAKE_INSTALL_INCLUDEDIR@

and so can’t handle absolute paths in CMAKE_INSTALL_{INCLUDE,LIB}DIR. This leads to broken .pc files on NixOS in particular.

Identical to https://github.com/libjxl/libjxl/issues/1400 (fixed). See “Concatenating paths when building pkg-config files” for a thorough discussion of the problem and a suggested fix, or KDE’s extra-cmake-modules for a simpler approach.

System

$ uname -a
Linux localhost 5.15.36 #1-NixOS SMP Wed Apr 27 12:39:02 UTC 2022 x86_64 GNU/Linux

Guida contributor

Direzione di ricerca
The bug is in the cmake/benchmark.pc.in file where libdir and includedir are always prefixed with prefix, even when they are absolute paths. The fix should check if the path is absolute before concatenating. Two approaches are referenced: using a helper function from cmake snips or the approach from KDE's extra cmake modules. The contributor should implement one of these and ensure the generated .pc file works correctly with absolute paths, such as on NixOS. No linked PRs or assignees.
Tech stack
cpp
Dominio
build system
Tipo issue
Bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
2
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 ore
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
Datata
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
Chiara
Prerequisiti
Basic understanding of CMakeFamiliarity with pkg config file format
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
70