golang/go

os: add test for Windows Dedup volumes

Open

#28.547 aperta il 2 nov 2018

Vedi su GitHub
 (1 commento) (0 reazioni) (0 assegnatari)Go (19.008 fork)batch import
BuildersFeatureRequestOS-WindowsTestinghelp wantednew-builder

Metriche repository

Star
 (133.883 star)
Metriche merge PR
 (Nessuna PR mergiata in 30 g)

Descrizione

In recent CL 143578, I was going to remove some code that I thought did nothing. My change would have made all files on Windows Dedup volumes ( https://docs.microsoft.com/en-us/windows-server/storage/data-deduplication/overview ) look like symlinks.

Luckily @kolyshkin pointed my mistake ( https://github.com/golang/go/issues/22579#issuecomment-428381201 ). I built Windows instance on Gogle Cloud with extra disk attached as D: drive and with Dedup option on, to test my CL.

I wonder, if we can have one of our Windows builders have small extra disk with Dedup on. Then we could write some appropriate tests that run on that builder.

/cc @bradfitz @johnsonj

Alex

Guida contributor