transport/http ServerFinalizer should accept error for better logging support
#807 aperta il 1 dic 2018
Metriche repository
- Star
- (27.422 star)
- Metriche merge PR
- (Nessuna PR mergiata in 30 g)
Descrizione
We have three systems where logs are sent: our internal ELK stack, NewRelic and Airbrake. Some of our endpoints send errors to all of this systems, some endpoints send errors to only one of it.
We want log entries to have both error message and http status code. And also some http request context (uri, method, user-agent, ip...)
The only place which has access to both error and http status is ServerErrorEncoder. But since different endpoints need different sets of log outputs, we would have to create multiple error encoders just for sake of logging. Also, ServerErrorEncoder is not a good place for logging, because we would like it to do only one job - encode errors.
ServerFinalizer seems to be a great place to send logs, but there is no access to actual error message.