ggml-org/whisper.cpp

Streaming to file leads to "duplicates"

Open

Aperta il 27 giu 2023

Vedi su GitHub
 (3 commenti) (0 reazioni) (0 assegnatari)C++ (49.693 star) (5535 fork)batch import
enhancementgood first issue

Descrizione

Hi all,

First of all, amazing work on this project. I'm really excited about what you're doing.

There's something I noticed about the way the ./stream works with the file parameter. I believe that for the stdout, it's only printing to a newline every n_new_line, and it would otherwise use a carriage return to overwrite the last line. This works nicely for stdout, but with the file output parameter, it's printed as a new line for every iteration.

I think this is buggy because the resulting text file has a bunch of duplicate lines most of the time, and it's difficult to parse out later. I'm guessing that this was written this way because you can't write carriage returns to a file and have it clear the last line like you can with stdout, but I think it would be a good compromise to only write to file on every n_new_line.

What do you think?

Guida contributor

Tech stack
cpp
Dominio
cli
Tipo issue
bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
half day
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
fresh
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
mostly clear
Prerequisiti
Basic C++ knowledgeUnderstanding of file I/O in C++
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
50
Direzione di ricerca
The issue reports that when streaming to a file, carriage returns are not handled, causing duplicate lines. Investigate the streaming code in the main file (e.g., main.cpp or stream.cpp) to understand how n new line and file output work. The fix would involve only writing to the file every n new line, similar to stdout behavior. Check if there is a separate file output function. Also review any related comments in the issue for maintainer input.