getredash/redash

Google Spreadsheets worksheet by title cleanup/refactor

Open

Aperta il 31 ago 2023

Vedi su GitHub
 (5 commenti) (3 reazioni) (1 assegnatario)Python (24.845 star) (4236 fork)batch import
enhancementgood first issue

Descrizione

In #5334 , I left a few comments about future work on the "fetch worksheet by title" functionality for the google spreadsheets query runner. We should address those, namely:

  • don't use mixed-type variables
  • allow for non-quoted worksheet titles (single word)
  • verify 0/1 indexing of worksheet numbers, and add comment if it differs

Guida contributor

Tech stack
python
Dominio
backendapi
Tipo issue
refactor
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 hours
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
Basic Python knowledgeFamiliarity with Redash plugin structure
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
40
Direzione di ricerca
Review the comments and code changes in PR #5334 to understand the existing implementation for fetching worksheet by title. Check the mixed type variables and decide on a consistent type. Look at how worksheet titles are currently quoted; extend support for non quoted single word titles. Verify the 0/1 indexing of worksheet numbers by examining the Google Sheets API documentation and the current usage in the codebase, then add clarifying comments.