getredash/redash

Query editor: format query feature breaks syntax of Postgres JSON operator

Open

Aperta il 8 nov 2021

Vedi su GitHub
 (2 commenti) (0 reazioni) (0 assegnatari)Python (24.845 star) (4236 fork)batch import
help wanted

Descrizione

Issue Summary

Query editor: format query feature breaks syntax of Postgres JSON operator

Steps to Reproduce

  1. WHERE keywords @> '[{"keyword":{"id":12345}}]'
  2. Valid according to: https://www.postgresql.org/docs/12/functions-json.html
  3. Gets formatted as keywords @ > '[{"keyword":{"id":12345}}]'
  4. This is invalid syntax because the @ and > have become separated

Technical details:

  • Redash Version: 10.0.0-beta (92e5d78d)

Guida contributor

Tech stack
javascriptreact
Dominio
frontend
Tipo issue
bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
2
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 hours
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
Familiarity with Redash query editor
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
70
Direzione di ricerca
Investigate the query formatting logic in the Redash frontend. Look for a SQL formatter function that tokenizes operators. The issue is that `@>` is being split into two tokens. Check if there is a list of operators that needs to include `@>` as a single token. Relevant code is likely in the client directory, possibly in a file like 'QueryEditor.jsx'. Review any existing tests for the formatter.