getredash/redash

Can't delete a data source if one of the queries references query result from it but uses a different data source

Open

Aperta il 29 mag 2019

Vedi su GitHub
 (6 commenti) (1 reazione) (1 assegnatario)Python (24.845 star) (4236 fork)batch import
BackendBughelp wanted

Descrizione

Issue Summary

When you have the following situation:

Query A references query result from data source A, but itself references data source B.

You will not be able to delete data source A, because it will fail to delete the query results using it.

Steps to Reproduce

The way the above can happen is if:

  1. You execute query A while it uses data source A and update it to use data source B.
  2. If the data source update happens right after this query was executed but before we actually update the query result reference.

It's an edge case, but happened already twice for people who reported it.

The correct solution here is to update the latest_query_data_id reference to get nullified if the query result is deleted.

Technical details:

  • Redash Version: 7

Guida contributor

Tech stack
python
Dominio
backend
Tipo issue
bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
half day
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
Python programmingSQLAlchemy ORMDatabase concepts
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
45
Direzione di ricerca
Examine the QueryResult model and the deletion logic in redash/models/ init .py around lines 304-309. The issue suggests nullifying the latest query data id when a query result is deleted. Review the database constraints and ensure no foreign key issues. Consider adding a migration if needed. Also check if there are any existing tests for this scenario.