getredash/redash

Visualization map (markers) doesn't reset with data

Open

Aperta il 20 gen 2019

Vedi su GitHub
 (0 commenti) (0 reazioni) (0 assegnatari)Python (24.845 star) (4236 fork)batch import
BugFrontendhelp wanted

Descrizione

Issue Summary

When I use a query filter to narrow down some geo data, the map view doesn't reset to line up with the map markers currently being displayed. The viewbox on the map stays wrapped around the first set of data (even after it disappears). So I have to zoom and drag the map manually to see the data.

Steps to Reproduce

  1. Load this data set from gh and then manipulate it with the Query Results data source.
  2. Use a query filter to limit the data by state name
  3. Make a map (markers) visualization
  4. Change the query filter
  5. Observe that the the map visualization doesn't update with a different data set.

I would expect the map to update its viewport to wrap around the most recently rendered coordiantes.

Technical details:

  • Redash Version: 431d6fa
  • Browser/OS: Chrome 71
  • How did you install Redash: Saas Product

Guida contributor

Tech stack
pythonjavascriptreact
Dominio
frontenddata
Tipo issue
bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
half day
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
JavaScriptReactMap libraryRedash development setup
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
70
Direzione di ricerca
Review the map visualization component in the Redash frontend codebase (likely under `client/app/components/visualizations/map/`). Understand how the viewport is set initially when data loads. Identify the logic that updates the viewport when data changes and ensure it resets the viewbox to fit new markers. Check if there is a method to fit bounds on data update. No linked PRs or comments exist.