getredash/redash

Load unformatted numbers from Google Spreadsheets

Open

Aperta il 10 ott 2018

Vedi su GitHub
 (6 commenti) (3 reazioni) (0 assegnatari)Python (24.845 star) (4236 fork)batch import
Backendenhancementhelp wanted

Descrizione

By default gspread loads formatted values from Google Spreadsheets, but it makes more sense to load unformatted values (123.0 instead of $123.0).

We use the get_all_values method. Unlike other getters this one doesn't take a value_render_option, but we can:

  1. Reimplement its behavior by using the lower level API it calls.
  2. Submit a pull request upstream to take this option for this method too.

Guida contributor

Tech stack
python
Dominio
backenddata
Tipo issue
feature
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
half day
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
Pythongspread libraryGoogle Sheets API
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
60
Direzione di ricerca
Investigate the current implementation of Worksheet.get all values in the redash codebase and the gspread library. The issue suggests two approaches: reimplement get all values to use the lower level API that supports value render option, or submit a pull request upstream to gspread to add support for value render option in get all values. Examine the gspread source to understand if the second approach is feasible and check if there are any existing PRs or discussions upstream. Based on findings, decide which approach is more appropriate and propose changes.