gchq/CyberChef

Bug report: ECC keys from "Generate PGP Key Pair" operation are invalid

Chiusa

#2267 aperta il 21 mar 2026

Vedi su GitHubGuida contributor
 (0 commenti) (0 reazioni) (1 assegnatario)JavaScript (3944 fork)batch import
bughelp wanted

Metriche repository

Star
 (34.843 stelle)
Metriche merge PR
 (Merge medio 57g 13h) (62 PR mergiate in 30 g)

Descrizione

Describe the bug ECC keys generated by the Generate PGP Key Pair operation are invalid because algorithm and curve type have not been set.

This results in PGP Encrypt operations using such a key failing with an obscure internal kbpgp message as per #1440, #1923.

To Reproduce See #1440 for example

Expected behaviour Key should have subkeys for signing/certification and encryption. See https://github.com/zapu/kbpgp/blob/4f61781c93798c0527f250332f50c47b73e878ca/test/files/cv25519.iced#L239-L249 for a reference example.

Additional context Long term it would probably be better to replace the kbpgp library with a more frequently updated/modern library such as openpgp.js

Guida contributor

Direzione di ricerca
First, examine the Generate PGP Key Pair operation in CyberChef's source code. Look at how key generation parameters are passed to kbpgp. The test file at https://github.com/zapu/kbpgp/blob/4f61781c93798c0527f250332f50c47b73e878ca/test/files/cv25519.iced#L239 L249 shows the correct way to set algorithm and curve. Identify where in the current code the algorithm and curve are missing and add them.
Tech stack
javascript
Dominio
securityfrontend
Tipo issue
Bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
2
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 ore
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
Bloccata
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
Chiara
Prerequisiti
PGP key generation basicskbpgp library
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
60