freezy/VisualPinball.Engine

Use LivecatchBounceMultiplier to reduce angular momentum instead of nulling it.

Open

#439 aperta il 29 ago 2022

Vedi su GitHub
 (0 commenti) (0 reazioni) (1 assegnatario)C# (72 fork)github user discovery
enhancementhelp wantedphysics

Metriche repository

Star
 (498 star)
Metriche merge PR
 (Metriche PR in attesa)

Descrizione

Currently, if a livecatch happens, angular momentum (only for x and y) is nulled, while livecatchbounceMultiplier is only used on velocity.

It could be tested, if the livecatches feel better, when the liveCatchBounceMultiplier (which is for example 0.2 for a slightly inaccurate livecatch) is not only applied to velocity, but also to the angular momentum.

	ball.Velocity -= collEvent.HitNormal * normalSpeed * liveCatchBounceMultiplier;
	ball.AngularMomentum.x = 0;
	ball.AngularMomentum.y = 0;

-->

	ball.Velocity -= collEvent.HitNormal * normalSpeed * liveCatchBounceMultiplier;
	ball.AngularMomentum.x *= liveCatchBounceMultiplier;
	ball.AngularMomentum.y *= liveCatchBounceMultiplier;

possibly only angular momentum in the direction of the collision-normal could be reduced. (like for velocity, or the same amount of the overall velocity reduction, otherwise calculation would be quite hard.)

Guida contributor