fossasia/visdom

Adding support for alpha channels

Chiusa

#694 aperta il 2 gen 2020

Vedi su GitHubGuida contributor
 (4 commenti) (0 reazioni) (0 assegnatari)Python (1152 fork)batch import
enhancementhelp wanted

Metriche repository

Star
 (9831 stelle)
Metriche merge PR
 (Merge medio 9g 12h) (116 PR mergiate in 30 g)

Descrizione

Currently, this project supports displaying greyscale and RGB images. However, many digital images also contain an alpha channel, and it would be nice to display images as RGBA, rather than converting them to RGB.

My initial investigation shows that simply changing the depth of the first axis from 3 to 4 in https://github.com/facebookresearch/visdom/blob/master/py/visdom/__init__.py#L1268 allows for proper display of RGBA images. Grayscale and RGB images would need to be converted to RGBA by adding a 'full' alpha channel.

Changing only the line as described above, and setting the background of the windows to green gives the following result: image

Guida contributor

Direzione di ricerca
The issue suggests modifying `py/visdom/ init .py` at line 1268 to change the depth of the first axis from 3 to 4. Additionally, grayscale and RGB images must be converted to RGBA by adding a full alpha channel. The existing code and image loading logic should be reviewed to ensure compatibility. No linked PRs or assignees, so the work is open.
Tech stack
pythonnumpy
Dominio
data
Tipo issue
Funzionalità
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
2
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 ore
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
Datata
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
Chiara
Prerequisiti
PythonNumPybasic git workflow
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
85