flipace/horizon-react

Error responses from websocket are swallowed

Open

#14 aperta il 28 lug 2016

Vedi su GitHub
 (2 commenti) (0 reazioni) (1 assegnatario)JavaScript (5 fork)github user discovery
bugenhancementhelp wanted

Metriche repository

Star
 (112 star)
Metriche merge PR
 (Metriche PR in attesa)

Descrizione

At the moment websocket error responses get swallowed and I have to manually inspect the messages to see what's wrong.

I've attempted to do:

collection.update(formData).subscribe(
  (d) => console.log('DONE', d),
  (err) => console.error(err),
)

Within my client code and changing https://github.com/flipace/horizon-react/blob/0806ede99abd4153117d6191dc10f9cce5bfbd20/src/components/subscribe.js#L206 to:


this.subscriptions[name] = {
  subscription: query
    .watch()
    .subscribe(
      this.handleData.bind(this, name),
      err => console.error(err)
    }),
  query: query._query
};

Neither of these will receive the error response. It's also not received by handleData (https://github.com/flipace/horizon-react/blob/0806ede99abd4153117d6191dc10f9cce5bfbd20/src/components/subscribe.js#L221)

Any guidance on how to go about this would be appreciated.

Guida contributor