finos/morphir-elm

Merge Record and ExtensibleRecord types in the IR

Aperta

#166 aperta il 30 set 2020

 (2 commenti) (0 reazioni) (0 assegnatari)Elm (69 fork)auto 404
good first issuehelp wantedir-simplification

Metriche repository

Star
 (51 stelle)
Metriche merge PR
 (Metriche PR in attesa)

Descrizione

Currently there are two separate constructors for Record and ExtensibleRecord in the IR: https://github.com/finos/morphir-elm/blob/55f27570f971e8c4e12fe1a0346dffdce594869e/src/Morphir/IR/Type.elm#L89-L90

These correspond to the following Elm code (excluding the left-hand-side):

type alias MyRecord =
    { foo : String
    }

type alias MyExtensibleRecord e =
    { e
        | foo : String
    }

The structure and semantics of the two definitions are very similar and in most cases the code that operates on them will share most of the logic so merging them will make the IR smaller and easier to process. This is one way to represent both with a single constructor:

    | Record a (Maybe Name) (List (Field a)) 

Acceptance Criteria

Guida contributor