files-community/Files

Code Quality: Replace references to Vanara and WinForms with CsWin32

Chiusa

#15.000 aperta il 19 mar 2024

 (11 commenti) (5 reazioni) (0 assegnatari)C# (2719 fork)batch import
help wanted

Metriche repository

Star
 (43.502 stelle)
Metriche merge PR
 (Merge medio 11g 15h) (61 PR mergiate in 30 g)

Descrizione

Description

We're working on utilizing Native Aot in the application, however, runtime marshaler is one of the blocker against this. Vanara uses loads of runtime marshaler via DllImport and ComImport and we're working on replacing it with CsWin32, ultimately removing its reference completely.

Concerned code

  • Vanara references
  • DllImport we explicitly use within the codebase

Gains

  • AoT compliant codebase
  • Less 3rd party references

Requirements

  • Replace DllImport with CsWin32

Comments

CsWin32 requires you to add interfaces, functions, constants, enums, snd etc in NativeMethods.txt placed in Files.App.CsWin32. #define'd constants also need to be written in that text file and use like "PInvoke.CMF_DEFAULT" (They don't get placed in a particular namespace). For more info, download ILSpy and win32metadata.winmd in order to see the full projections.

Guida contributor