feathr-ai/feathr

Path concatenation without forward slash

Open

Aperta il 23 mag 2022

Vedi su GitHub
 (0 commenti) (0 reazioni) (0 assegnatari)Scala (1929 star) (244 fork)batch import
featuregood first issue

Descrizione

This is reported by Manjunath from Slack channel. For work_dir: "dbfs:/feathr_getting_started" The user was running jupyter notebook from windows. without forward slash('dbfs:/feathr_getting_started') the job configs were coming as '--join-config', 'dbfs:/feathr_getting_started\feature_join.conf'

To fix this, the user need to add foward slash: work_dir: "dbfs:/feathr_getting_started"

We should add validation or automatically append a forward slash. The best way would be using Path utils that can join files/folders properly.

Guida contributor

Tech stack
scalapythonspark
Dominio
data
Tipo issue
bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
2
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
under 1 hour
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
Nessuno
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
80
Direzione di ricerca
The issue is about path concatenation errors when work dir lacks a trailing slash. The fix should involve adding validation or using path joining utilities (e.g., os.path.join in Python, Path in Scala) to ensure proper joining. Look at the configuration handling code, possibly in the Python SDK or Scala job submission components. Test on Windows to confirm the fix.