facebookexperimental/Recoil

[Performance] Short-circuit set recoil state if the value is unchanged

Open

Aperta il 30 lug 2022

Vedi su GitHub
 (7 commenti) (1 reazione) (0 assegnatari)JavaScript (19.428 star) (1151 fork)batch import
help wantedperformance

Descrizione

It seems that the current implementation of setting recoil state can be further improved when the value is the same as the current value. In this case, we don't have to go through all the enchilada and more importantly don't have to call setState in the end, which is not exactly cost free. I have observed major performance hit thanks to that. I have to cache the previous value myself and do the equality check before calling set recoil state when recoil has all the knowledge to that.

Guida contributor

Tech stack
javascriptreact
Dominio
performancefrontend
Tipo issue
performance
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 hours
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
JavaScriptReactRecoil fundamentals
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
40
Direzione di ricerca
Look at the Recoil source code related to state updates, specifically the `setRecoilState` function. Identify where the state is updated and add an equality check to short circuit if the value is unchanged. Consider using a shallow comparison for objects. Check existing comments for additional context.