facebookexperimental/Recoil

[React Native] "Setting a timer for a long period of time" warning

Open

Aperta il 16 mag 2021

Vedi su GitHub
 (8 commenti) (32 reazioni) (0 assegnatari)JavaScript (19.428 star) (1151 fork)batch import
help wantednative

Descrizione

Version 0.3.0 produces warning:

 WARN  Setting a timer for a long period of time, i.e. multiple minutes, is a performance and correctness issue on Android as it keeps the timer module awake, and timers can only be called when the app is in the foreground. See https://github.com/facebook/react-native/issues/12981 for more info.

Happens because of https://github.com/facebookexperimental/Recoil/blob/master/src/hooks/Recoil_Hooks.js#L60.

Any plans to fix it?

Guida contributor

Tech stack
javascriptreactreact native
Dominio
frontend
Tipo issue
bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 hours
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
React Native basicsunderstanding of JavaScript timers
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
50
Direzione di ricerca
The warning occurs at https://github.com/facebookexperimental/Recoil/blob/master/src/hooks/Recoil Hooks.js#L60 due to a long timer. The fix involves replacing the timer with a React Native friendly approach, such as using InteractionManager.runAfterInteractions or a native module. Review the React Native issue linked (facebook/react native#12981) for guidance on avoiding this warning. The change is localized to a single file.