facebookarchive/prepack

Rewrite reportIntrospectionError calls

Open

#1898 aperta il 8 mag 2018

Vedi su GitHub
 (8 commenti) (0 reazioni) (0 assegnatari)JavaScript (520 fork)batch import
enhancementhelp wanted

Metriche repository

Star
 (14.268 star)
Metriche merge PR
 (Nessuna PR mergiata in 30 g)

Descrizione

Once upon a time, Prepack didn't have a real error-handling story besides just throwing an exception. From this time, there are still a ton of reportIntrospectionError calls in the code base.

They should all be rewritten, one by one (separate pull-requests, please) into something like the following.

    let error = new CompilerDiagnostic("appropriate error message", referenceToSourceLocation, "PPxxxx", "FatalError");
    realm.handleError(error);
    throw new FatalError();

Where PPxxxx should be the next currently unused error code; check https://github.com/facebook/prepack/wiki/Prepack-diagnostics for all currently defined error code.

  • Create a new wiki page with the PP error number as its name.
  • Add a link to it from the page that lists all error numbers.

Guida contributor