facebook/fresco

SvgDecoderExample limit <svg tag

Open

Aperta il 20 apr 2020

Vedi su GitHub
 (2 commenti) (0 reazioni) (0 assegnatari)Java (17.072 star) (3750 fork)batch import
enhancementgood first issuehelp wanted

Descrizione

We use GitHub Issues for bugs.

If you have a non-bug question, please ask on Stack Overflow: http://stackoverflow.com/questions/tagged/fresco

--- Please use this template, and delete everything above this line before submitting your issue ---

Description

I want use SimpleDraweeView to .setImageURI(Uri.parse("https://www.ups.com/assets/resources/images/UPS_logo.svg")); but the svg file is start with <?xml tag, so SvgDecoderExample.SvgFormatChecker() is block it.

Solution

I try update SvgDecoderExample.java line 33 : private static final String HEADER_TAG = "<svg"; to private static final String HEADER_TAG = "<?xml"; let it thought the cheker, it is visible now.
why you want to block the tag?
The AndroidSVG('com.caverock:androidsvg:1.2.1') lib is work find.

Additional Information

  • Fresco version: 'com.facebook.fresco:fresco:2.0.0'

Guida contributor

Tech stack
javaandroid
Dominio
mobile
Tipo issue
bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
2
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
under 1 hour
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
JavaAndroid
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
85
Direzione di ricerca
The issue is in SvgDecoderExample.java on line 33 where the constant HEADER TAG checks only for '<svg'. The reporter suggests changing it to '<?xml' or accepting both. The maintainer should confirm if files starting with <?xml are valid SVG and whether the fix should allow both patterns. Check the AndroidSVG library documentation for supported SVG root tags.