facebook/flipper

FlipperOkhttpInterceptor making SSE not working

Open

Aperta il 21 giu 2021

Vedi su GitHub
 (11 commenti) (16 reazioni) (0 assegnatari)TypeScript (13.028 star) (972 fork)batch import
PR welcomehelp wantedplugin-network

Descrizione

🐛 Bug Report

in the reactNativeFlipper.java, the following lines making EventSource (SSE) not working.

....
NetworkFlipperPlugin networkFlipperPlugin = new NetworkFlipperPlugin();
      NetworkingModule.setCustomClientBuilder(
          new NetworkingModule.CustomClientBuilder() {
            @Override
            public void apply(OkHttpClient.Builder builder) {
              builder.addNetworkInterceptor(new FlipperOkhttpInterceptor(networkFlipperPlugin));
            }
          });

Environment

Android, Flipper 0.93, react native 0.64.0

Guida contributor

Tech stack
androidjavareact native
Dominio
mobiletesting
Tipo issue
bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 hours
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
Android developmentOkHttp interceptorsSSE basics
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
25
Direzione di ricerca
Investigate the FlipperOkhttpInterceptor class in the Flipper Android SDK to understand how it intercepts network requests. The issue is in reactNativeFlipper.java where the interceptor is added via builder.addNetworkInterceptor(). Focus on how the interceptor might consume the response body or modify headers, breaking SSE's streaming behavior. Refer to OkHttp documentation on network interceptors and consider testing with a minimal React Native Android app using EventSource. Check if the issue was resolved in later versions of Flipper.