expressjs/multer

Wrong error sometimes for file that's too large?

Open

Aperta il 6 ott 2016

Vedi su GitHub
 (2 commenti) (0 reazioni) (0 assegnatari)JavaScript (11.136 star) (1043 fork)batch import
futurehelp wanted

Descrizione

Having trouble reproducing this, but for a while today I was receiving a confusing error, 'Unexpected field' (a.k.a. LIMIT_UNEXPECTED_FILE). Searching Stack Overflow I found that this error was mostly caused by a mismatch between the "name" string in the form and the one in my Express route. But that wasn't it because they were both called "image."

I tried re-installing the module but still got the same error. Then I switched to a much smaller file and Multer started working again without the "unexpected field" error. Then, to test my theory I tried uploading a large file, only this time to receive the correct "request entity too large" error.

Also I wonder if there has been discussion of providing an easier-to-understand, separate error message like

"Error: Multer requires a 'name' attribute that matches the one in the route, but received: 'picField'"

Seems like it would save a lot of time for folks...

Guida contributor

Tech stack
javascriptnodejsexpress
Dominio
backend
Tipo issue
bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
half day
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
needs investigation
Prerequisiti
Node.jsMulter
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
20
Direzione di ricerca
Investigate the conditions under which Multer throws LIMIT UNEXPECTED FILE instead of LIMIT FILE SIZE for large files. Review the error handling logic in lib/multer.js and the busboy library to understand how file size limits are enforced. Consider adding a separate error code or improving error messages to distinguish between missing fields and oversized files.