expressjs/cors

Add ability to omit `Vary: Origin` header

Open

Aperta il 21 mar 2024

Vedi su GitHub
 (6 commenti) (0 reazioni) (0 assegnatari)JavaScript (5897 star) (476 fork)batch import
enhancementhelp wanted

Descrizione

Hello! Thank you to the authors and maintainers for this important package.

We have an issue where we would like the ability to conditionally omit Vary: Origin as a header. In our use case, we have specific routes for which the responses does not vary based on the requesting origin, e.g. a route for vending static image content.

Without this functionality, we are unable to use Cloudflare Polish1, which only accepts Vary: Accept-Encoding2, short of effectively rewriting all the cors code minus the Vary: Origin header.

Would this repository be able to add this functionality, or accept a patch to allow conditionally removing this header based on the requested routes?

Thank you again!

Footnotes

  1. https://developers.cloudflare.com/images/polish/ ↩

  2. https://developers.cloudflare.com/images/polish/cf-polished-statuses/ ↩

Guida contributor

Tech stack
javascriptnodejsexpress
Dominio
backend
Tipo issue
feature
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
2
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
1-3 hours
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
active
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
JavaScriptNode.jsExpress.jsCORS basics
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
60
Direzione di ricerca
Examine the main source file (e.g., lib/cors.js) to understand how the Vary header is currently set. Review the existing options and their handling. Consider adding a new option that allows users to conditionally omit the Vary: Origin header. Look at the test suite to understand how tests are structured and add corresponding tests.