envoyproxy/envoy

bug: lambda captures destruction order not determined.

Open

#7184 aperta il 5 giu 2019

Vedi su GitHub
 (3 commenti) (0 reazioni) (0 assegnatari)C++ (5373 fork)batch import
bughelp wanted

Metriche repository

Star
 (27.997 star)
Metriche merge PR
 (Merge medio 8g) (378 PR mergiate in 30 g)

Descrizione

Title: [BUG] lambda captures destruction order not determined in http ConnectionManagerImpl factory callback.

Description:

In envoy/source/extensions/filters/network/http_connection_manager/config.cc when return the ConnectionManagerImpl factory callback, the created HttpConnectionManagerConfig instance "filter_config" takes reference of objects held by shared_ptr route_config_provider_manager and date_provider etc.

Per https://en.cppreference.com/w/cpp/language/lambda the order of captures construction(so destruction as well) is not determined. This may cause issue during destruction of the "filter_config" object.

Repro steps:

It's kinda hard to reproduce as it's compiler dependent. but a easy fix is to fix the order by capturing them in a temp struct or something similar before diving into the lambda.

Note: N/A

Admin and Stats Output: N/A Config: N/A

Logs:N/A Call Stack:N/A

Guida contributor