envoyproxy/envoy

cleanup: add proto definition for test extensions

Chiusa

#20.476 aperta il 23 mar 2022

Vedi su GitHubGuida contributor
 (5 commenti) (0 reazioni) (0 assegnatari)C++ (5373 fork)batch import
area/protobufbeginnerbughelp wantedtech debt

Metriche repository

Star
 (27.997 stelle)
Metriche merge PR
 (Merge medio 8g) (378 PR mergiate in 30 g)

Descrizione

Currently, lookup-by-name for extensions is used for internal extensions. This is inconsistent with actual extensions which exclusively use lookup-by-type-URL. The cleanup is to add protos for all internal extensions, and remove the runtime guard usage in the tests.

Guida contributor

Direzione di ricerca
Investigate the existing internal extensions in 'source/extensions/' directory. Examine proto definitions for external extensions (e.g., 'api/envoy/extensions/') to understand the pattern. Find all uses of lookup by name and runtime guards in test files. The goal is to add proto definitions for each internal extension and refactor tests to use lookup by type URL. Refer to any comments or linked PRs in issue #20476 for additional context.
Tech stack
cpp
Dominio
backendinfrastructure
Tipo issue
Refactoring
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
3
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
3-5 giorni
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
Datata
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
Chiara
Prerequisiti
C++ knowledgeProtocol BuffersEnvoy internalsTesting experience
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
30