Send custom key-value pairs in ot-span-context to Zipkin · envoyproxy/envoy#2031

(3 commenti) (1 reazione) (0 assegnatari)C++ (5373 fork)batch import

area/tracingenhancementhelp wanted

Metriche repository

Thanks for maintaining the great project 👍

Envoy does seem to propagate ot-span-context but drops most of the key-values included in it before sending it to Zipkin.

Would it be possible to send those key-values as binary annotations of Zipkin spans? Could I contribute it?

Context:

After looking into code, it turns out that Envoy as of today drops all the keys in ot-span-context other than a few, well-known keys like traceid and spanid, before sending these to Zipkin.
AFAIK, ot-span-context could be populated with "custom" keys and values other than these, e.g. by our apps, to provide additional context throughout multiple spans in single trace.
If Envoy could translate those to corresponding binary annotations in Zipkin spans, we could view those custom key-value pairs from ot-span-context in Zipkin.
FYI, an app like dd-zipkin-proxy allows Datadog to consume Zipkin spans containing arbitrary binary annotations so that it would also help Datadog users.

Direzione di ricerca: Ispeziona il codice sorgente in source/common/tracing/zipkin/tracer.cc, in particolare le righe 53-114, per capire come viene analizzato ot span context e come vengono creati gli span Zipkin. Identifica dove aggiungere coppie chiave valore personalizzate come annotazioni binarie. Quindi implementa le modifiche necessarie per propagare tali coppie.
Tech stack: cpp
Dominio: observabilitybackend
Tipo issue: Funzionalità
Difficoltà: 2
Tempo stimato: 1-3 ore
Stato attività: Attiva
Chiarezza: Chiara
Prerequisiti: C++Envoy codebase understandingZipkin tracing
Adatta ai principianti: 45