emscripten-core/emscripten

Use WeakRefs in event handlers?

Open

#9820 aperta il 11 nov 2019

Vedi su GitHub
 (3 commenti) (0 reazioni) (0 assegnatari)C++ (3519 fork)batch import
good first bughelp wanted

Metriche repository

Star
 (27.361 star)
Metriche merge PR
 (Merge medio 19g 10h) (147 PR mergiate in 30 g)

Descrizione

See e.g. https://github.com/emscripten-core/emscripten/issues/5456#issuecomment-552005331 and other reports in the past. If one creates event handlers then the module cannot be GC'd even if nothing but the event handlers refers to it. The handlers must be unregistered manually.

If all event handlers used a WeakRef to everything else, then the module can be gc'd, and then the event handler can see it can just exit (and unregister itself).

As WeakRefs are not supported everywhere yet, we'd need to check for their presence.

I'm not sure if this would need to be an option or not. Doing it automatically would help some things, but maybe some codebases do want to stay alive due to event handlers.

Guida contributor