elsa-workflows/elsa-core

IUserTaskService enhancement - optional activityId

Aperta

#4535 aperta il 13 ott 2023

 (3 commenti) (0 reazioni) (0 assegnatari)C# (979 fork)batch import
bugelsa 2elsa 3enhancementgood first issuetriaged

Metriche repository

Star
 (5486 stelle)
Metriche merge PR
 (Merge medio 1g 17h) (29 PR mergiate in 30 g)

Descrizione

The IUserTaskService is great but, I think it needs an improvement.

Specifically, i think the TriggerUserAction record needs an optional activityId, to be absolutely specific if the action being performed is going to target the correct activity.

public record TriggerUserAction(string Action,string? WorkflowInstanceId = default,string? CorrelationId = default );

to become

public record TriggerUserAction(string Action,string? WorkflowInstanceId = default, string? ActivityId = default, string? CorrelationId = default );

If you consider the possibility that a Fork has a blocking activity on each branch, and each perhaps has the same outcome names, then the specificity requires in that use providing the activityId.

This change would also predicate the IUserTaskService needing two additional methods:

        Task< CollectedWorkflow> ExecuteUserActionAsync(TriggerUserAction taskAction, CancellationToken cancellationToken = default(CancellationToken));

        Task<CollectedWorkflow> DispatchUserActionAsync(TriggerUserAction taskAction, CancellationToken cancellationToken = default(CancellationToken));

Guida contributor