element-hq/element-android

Create booleans to configure preferences (settings screens) easily

Aperta

#5366 aperta il 25 feb 2022

 (1 commento) (0 reazioni) (0 assegnatari)Kotlin (912 fork)auto 404
A-Settingshelp wanted

Metriche repository

Star
 (3713 stelle)
Metriche merge PR
 (Metriche PR in attesa)

Descrizione

Create a set of booleans to configure preferences screens easily. It also has the advantage to centralize the default value for each setting. Before 2 boolean values had to be changed to change the default value of a preference (one in the XML and one in the file VectorPreferences.kt).

There is now a boolean to show or hide the setting in the preference screen, and a boolean for the default value of the preference.

It has been done for the root preference screen and the message bubbles: see here and the PR #5157 for more details.

Now we should do it for every single preference, which is, let's be honest, a boring and fastidious work.

If anyone in the community wants to give us a hand, it will be appreciated. It can of course be split into several small PRs (say one PR per preference screen). Every small PR will be appreciated!

Guida contributor