elastic/logstash

Delete batch files from deb (and rpm) packages

Open

Aperta il 18 mar 2015

Vedi su GitHub
 (2 commenti) (0 reazioni) (0 assegnatari)Ruby (14.197 star) (3496 fork)batch import
buggood first issuehacktoberfestpackaging

Descrizione

I noticed on my Linux system, when using the package that it is also installing .bat files (for Windows) along with the bash scripts to run the script.

Here is a patch that should take care of removing them before building the package (untested):

diff --git a/pkg/build.sh b/pkg/build.sh
index 8ad876b..0d56ab4 100755
--- a/pkg/build.sh
+++ b/pkg/build.sh
@@ -41,6 +41,9 @@ fi

 tar -C $destdir/$prefix --strip-components 1 -zxpf $tar

+# Delete batch files
+rm -f $destdir/opt/logstash/bin/*.bat
+
 case $os@$release in
  centos@*|fedora@*|el6@*|sl6@*)
     mkdir -p $destdir/etc/logrotate.d

Guida contributor

Tech stack
shell
Dominio
devops
Tipo issue
bug
DifficoltàQuanto dovrebbe essere impegnativa per un nuovo contributor.
2
Tempo stimatoTempo stimato per completare e verificare uno scope piccolo.
under 1 hour
Stato attivitàQuanto è probabile che la issue sia ancora attiva e reviewable.
stale
ChiarezzaQuanto chiaramente la issue descrive problema, scope e risultato atteso.
clear
Prerequisiti
basic shell scripting
Adatta ai principiantiQuanto la issue è adatta a contributor alla prima esperienza.
85
Direzione di ricerca
Check if the .bat files are still included in the Linux packages by building Logstash locally using the scripts in pkg/build.sh. If the issue persists, apply the provided patch and test the build for both deb and rpm packages. Also, review the git history to see if this fix was already implemented in a later commit.